Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login sidebar width on very wide displays #20260

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

filiptronicek
Copy link
Member

Description

The sidebar on wider displays would occupy ⅓ of the entire screen, which is fine until you bring in an ultrawide monitor. This PR caps the sidebar's width at 32rem.

Related Issue(s)

Fixes https://gitpod.slack.com/archives/C071G5TTS49/p1727791851430539

How to test

https://ft-fix-login-flicker.preview.gitpod-dev.com/workspaces

@filiptronicek filiptronicek requested review from a team as code owners October 2, 2024 06:47
@filiptronicek filiptronicek changed the title Fix sidebar width on very wide displays Fix login sidebar width on very wide displays Oct 2, 2024
@roboquat roboquat added the size/S label Oct 2, 2024
Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@roboquat roboquat merged commit e63652e into main Oct 2, 2024
25 of 27 checks passed
@roboquat roboquat deleted the ft/fix-login-flicker branch October 2, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants