Reapply "[supervisor] set pod failure reason when supervisor is reaped" #20327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
approved these changes
Oct 29, 2024
|
@mustard-mh if you enable with-large-vm, and disable preemptible, the preview VM will be much more stable:
|
|
@filiptronicek @kylos101 thank you for your helps! I plan to:
Will update you if I made any progress |
This reverts commit 1473e3d.
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: golang/github.com/ramr/[email protected] |
|
We did some manual testings on a production installation [internal chat], with the latest changes and reproduce steps, 25/25 workspaces are working well with gitpod-io/gitpod repo. /unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/hold
How to confirm root problem? Check AWS S3 content which is backed up from @kylos101 's reproduce workspace, unzip tar and check logs of
/workspace/.gitpod/supervisor-termination.log, the log is print byprocess.kill[relevant code refer [1] [2]]. So once we receive signals, we should ignore the case (if dev/term/log is empty as well)Related Issue(s)
Fixes CLC-877
How to test
Repeat steps in #20318 and:
gp timeout set 1mCompare with a reproducible preview env https://hw-clc-877-reproduce.preview.gitpod-dev.com/workspaces, you should be able to reproduce it with gitpod-io/gitpod repo (try with 4 workspaces). (You may need to recreate preview env if it's deleted with branch
hw/CLC-877-reproduce> execleeway run dev:preview(Or use https://github.com/mustard-mh/test/tree/hw/hang-task instead, as gitpod repo is too large to start in preview env -> no space left)
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold