Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] do not show repo examples from incompatible providers #20335

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

filiptronicek
Copy link
Member

Description

Prevents showing a given example repository when it cannot be opened given the current auth provider configuration.

Related Issue(s)

Fixes CLC-902

How to test

You can test by opening https://ft-fix-una8406a84f5e.preview.gitpod-dev.com/workspaces and seeing that there are still only 2 suggested repositories, both from github.com. In the actual preview env, there is a third one on an arbitrary host, but it is correctly not visible because there is no auth setup with it.

/hold

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and there're only two repositories (both under github.com) in preview env

image

@roboquat roboquat merged commit ca204e4 into main Oct 31, 2024
33 checks passed
@roboquat roboquat deleted the ft/fix-unavailable-repository-examples branch October 31, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants