Fix Dockerfile paths with relative decorators #20365
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you pointed to your Dockerfile with
./.gitpod.Dockerfileinstead of.gitpod.Dockerfile, it would fail. That is simply because SCM APIs (at least GitHub, which I've checked) expect a path without any relative decorators relative to the repository root.Related Issue(s)
Fixes CLC-926
How to test
Try to open filiptronicek/test-foofies@2b2ae74 in the e and in Catfood. It will give you a warning in Catfood, but should not in the preview env.
/hold