JetBrains IDEs 2024.3 stable release
#20370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
force-pushed
the
hw/CLC-941
branch
from
ca7f3a5
to
1221cd9
Compare
mustard-mh
commented
Nov 15, 2024
| @@ -151,6 +151,7 @@ packages: | |||
| - NO_VERIFY_JB_PLUGIN=true | |||
| config: | |||
| commands: | |||
| - ["rm", "-rf", "src/main/kotlin/io/gitpod/jetbrains/remote/GitpodMetricControlProvider.kt"] | |||
There was a problem hiding this comment.
To unblock rider plugin build
mustard-mh
commented
Nov 15, 2024
| return image.replace("gitpod-dev-artifact", "gitpod-core-dev"); | ||
| for (const imgFromMain of imagesBuildFromMain) { | ||
| if (image.includes(imgFromMain)) { | ||
| return image.replace("gitpod-dev-artifact", "gitpod-core-dev"); |
There was a problem hiding this comment.
Make sure we could use these images built from main in preview env, repository is set by installer, we correct it in this patch script
gitpod-dev-artifact- dev imagesgitpod-core-dev- prod images from main
mustard-mh
commented
Nov 15, 2024
| @@ -814,10 +862,10 @@ | |||
| "logo": "{{.IdeLogoBase}}/clionLogo.svg", | |||
| "image": "{{.Repository}}/ide/clion:{{.WorkspaceVersions.Workspace.DesktopIdeImages.CLionImage.Version}}", | |||
| "latestImage": "{{.ResolvedJBImageLatest.CLion}}", | |||
| "pluginImage": "{{.JetBrainsPluginImage}}", | |||
| "pluginImage": "{{.JetBrainsPluginImagePrevious}}", | |||
There was a problem hiding this comment.
CLion and RustRover 2024.3 are not release yet, we need to force them to use old backend plugin
There was a problem hiding this comment.
Rider is a special one, we don't take care of it for a long time already, (it had a bug before that we can't build, and the bug was fixed, but we don't have time to work on it)
mustard-mh
commented
Nov 15, 2024
| @@ -67,6 +68,9 @@ func GenerateIDEConfigmap(ctx *common.RenderContext) (*ide_config.IDEConfig, err | |||
| WorkspaceVersions versions.Components | |||
| } | |||
|
|
|||
| // {{.Repository}}/ide/jb-backend-plugin:commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6 | |||
| previousStableJetBrainsBackendPluginVersion := "commit-4c69ad0670cc4cfbf43910e1db700ad90acd5ac6" | |||
There was a problem hiding this comment.
The value is a copy current stable backend plugin image from main build
mustard-mh
force-pushed
the
hw/CLC-941
branch
from
544148d
to
9622ed1
Compare
6 tasks
iQQBot
approved these changes
Nov 15, 2024
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes CLC-941
How to test
✅ Smoke test
2024.32024.32024.2✅ Integration tests should pass
https://github.com/gitpod-io/gitpod/actions/runs/11859552844/job/33053613264?pr=20370
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold