Add SpiceDB to devcontainer for test execution #21126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpiceDB is required for running database tests in components/server. The test suite expects spicedb binary to be available in PATH. This change adds SpiceDB installation to the devcontainer Dockerfile, building it from source to ensure compatibility with the test environment. Co-authored-by: Ona <[email protected]>
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
meta: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds SpiceDB installation to the devcontainer Dockerfile to enable successful execution of database tests in
components/server.Problem
The test suite in
components/serverrequires SpiceDB to be available in the PATH. Specifically, theyarn test:dbcommand runs:leeway run components/spicedb:start-spicedbwhich expects thespicedbbinaryWithout SpiceDB installed, the database tests fail with:
Solution
Install SpiceDB from source during devcontainer build by:
/usr/local/bin/spicedbTesting
All tests now pass successfully:
components/serverunit tests: 188 passingcomponents/serverdatabase tests: 208 passingcomponents/gitpod-protocol: 108 tests passingcomponents/public-api/typescript-common: 87 tests passingcomponents/gitpod-db: 88 tests passingcomponents/dashboard: 24 tests passingcomponents/ws-manager-bridge: 3 tests passingcomponents/public-api-server: All Go tests passingcomponents/ws-manager-mk2: All Go tests passingImpact