Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceAccount template #4

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add ServiceAccount template #4

merged 2 commits into from
Oct 22, 2024

Conversation

zktaiga
Copy link
Contributor

@zktaiga zktaiga commented Oct 20, 2024

Pull Request Template for Helm Chart

Description

Creates a ServiceAccount

Fixes # #3

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Local testing

Test Configuration:

  • Kubernetes version: v1.30.3
  • Helm version: v3.14.3
  • Minikube/kind version (if applicable):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Additional Information

  • Does this change introduce any new Kubernetes resource types? Yes
    If yes, please list them: Single ServiceAccount

  • Does this change modify any existing Kubernetes resource types? No
    If yes, please describe the modifications:

  • Are there any changes to the values.yaml file? No
    If yes, please describe the changes and their purpose:

  • Does this change require any specific Kubernetes permissions or RBAC changes? No
    If yes, please describe the required permissions:

  • Are there any changes to chart dependencies? No
    If yes, please list the changes:

  • Have you updated the CHANGELOG.md file? Bumped Helm version

Additional context

Add any other context or screenshots about the pull request here.

@jamesread
Copy link
Contributor

Hey @zktaiga , many thanks - I've send your PR to CI to test.

@jamesread
Copy link
Contributor

The lint looks good, merging :-) Many thanks for the PR @zktaiga !

@jamesread jamesread closed this Oct 22, 2024
@jamesread jamesread reopened this Oct 22, 2024
@jamesread jamesread merged commit 465e817 into gitroomhq:main Oct 22, 2024
3 checks passed
@zktaiga zktaiga deleted the add/sa branch October 22, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants