Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add volumes / fix issue with port #5

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Mattchewone
Copy link
Contributor

Pull Request Template for Helm Chart

Description

Add optional volumes & fix issue with exposed port from deployment.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally on a deployed K3s instance

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Additional Information

  • Does this change introduce any new Kubernetes resource types? (No)
    If yes, please list them:

  • Does this change modify any existing Kubernetes resource types? (Yes)
    If yes, please describe the modifications:
    Added volumeMounts for uploads

  • Are there any changes to the values.yaml file? (No)
    If yes, please describe the changes and their purpose:

  • Does this change require any specific Kubernetes permissions or RBAC changes? (No)
    If yes, please describe the required permissions:

  • Are there any changes to chart dependencies? (No)
    If yes, please list the changes:

  • Have you updated the CHANGELOG.md file? (No)

Additional context

Add any other context or screenshots about the pull request here.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@jamesread
Copy link
Contributor

This LGTM, I've sent it to CI :-) Thanks very much @Mattchewone .

@jamesread
Copy link
Contributor

Hey @Mattchewone , looks like the job failed, needing a version bump.

It's a bit weird how that works - I didn't set that bit up, and I'll try and fix the job later. Would you mind just bumping to 1.0.4 in the chart.yaml to see if that fixes the job?

@Mattchewone
Copy link
Contributor Author

Hey @Mattchewone , looks like the job failed, needing a version bump.

It's a bit weird how that works - I didn't set that bit up, and I'll try and fix the job later. Would you mind just bumping to 1.0.4 in the chart.yaml to see if that fixes the job?

Ah ok, sure let me try that.

@timoa
Copy link

timoa commented Oct 30, 2024

Great PR! I tried it, and it fixed the issue with the app loading on the wrong port (3000 instead of 5000).

@Mattchewone Can you please, add the following values into the values.yaml file?

extraVolumes: []
extraVolumeMounts: []

Without, we get two issues with Helm-Intellisense:

Value not defined
postiz-deployment.yaml(42, 24): .Values.extraVolumeMounts
Value not defined
postiz-deployment.yaml(68, 20): .Values.extraVolumes

@jamesread
Copy link
Contributor

I'd be happy to merge this now, but @Mattchewone , could you consider @timoa 's comments please? I'm indifferent (don't mind) about adding them, I think.

@Mattchewone
Copy link
Contributor Author

@timoa / @jamesread sorry I was away so couldn't respond.

I've updated. Hopefully this resolves any issues with the linter.

@jamesread
Copy link
Contributor

LGTM, merging :-)

@jamesread jamesread merged commit f09e2ff into gitroomhq:main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants