clippy

gjtorikian · Jul 14, 2024 · 0787004 · 0787004
1 parent cca019f
commit 0787004
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/ext/selma/src/html/element.rs b/ext/selma/src/html/element.rs
@@ -119,11 +119,10 @@ impl SelmaHTMLElement {
                 .iter()
                 .for_each(|attr| match hash.aset(attr.name(), attr.value()) {
                     Ok(_) => {}
-                    Err(err) => Err(Error::new(
+                    Err(err) => panic!("{:?}", Error::new(
                         exception::runtime_error(),
                         format!("AttributeNameError: {err:?}"),
-                    ))
-                    .unwrap(),
+                    )),
                 });
         }
         Ok(hash)
@@ -139,7 +138,7 @@ impl SelmaHTMLElement {
             .for_each(|ancestor| match array.push(RString::new(ancestor)) {
                 Ok(_) => {}
                 Err(err) => {
-                    Err(Error::new(exception::runtime_error(), format!("{err:?}"))).unwrap()
+                    panic!("{:?}", Error::new(exception::runtime_error(), format!("{err:?}")))
                 }
             });
 

diff --git a/ext/selma/src/native_ref_wrap.rs b/ext/selma/src/native_ref_wrap.rs
@@ -1,5 +1,4 @@
 use std::{
-    cell::RefCell,
     marker::PhantomData,
     sync::{Arc, Mutex},
 };
@@ -22,7 +21,7 @@ impl<'r> Anchor<'r> {
 
 // impl Drop for Anchor<'_> {
 //     fn drop(&mut self) {
-//         self.poisoned.replace(true);
+//         *self.poisoned.lock().unwrap() = true;
 //     }
 // }
 

diff --git a/ext/selma/src/sanitizer.rs b/ext/selma/src/sanitizer.rs
@@ -338,7 +338,7 @@ impl SelmaSanitizer {
         element: &mut Element,
         element_sanitizer: &ElementSanitizer,
         attr_name: &String,
-        attr_val: &String,
+        attr_val: &str,
     ) -> Result<bool, AttributeNameError> {
         let mut allowed: bool = false;
         let element_allowed_attrs = element_sanitizer.allowed_attrs.contains(attr_name);
@@ -390,7 +390,7 @@ impl SelmaSanitizer {
         attr_val.contains("://")
     }
 
-    fn has_allowed_protocol(protocols_allowed: &[String], attr_val: &String) -> bool {
+    fn has_allowed_protocol(protocols_allowed: &[String], attr_val: &str) -> bool {
         if protocols_allowed.contains(&"all".to_string()) {
             return true;
         }
@@ -549,7 +549,7 @@ impl SelmaSanitizer {
     ) -> &'a mut ElementSanitizer {
         element_sanitizers
             .entry(element_name.to_string())
-            .or_insert_with(ElementSanitizer::default)
+            .or_default()
     }
 }