Skip to content
This repository has been archived by the owner on Apr 16, 2021. It is now read-only.

Set content type for AWS S3 buckets for the s3-upload goal #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Pitxyoki
Copy link
Contributor

This adds the same functionality that was added by PR #27 to the AWS S3 wagon plugin, only for the S3UploadMojo class, corresponding to the s3-upload goal.

Note that the ContentTypeResolver class was moved to the cloud-storage-core module so that the code could be reused across the two plugins (Azure and S3).

@Pitxyoki
Copy link
Contributor Author

Initially, I was doing as the PR describes. However, today I found out that the AWS S3 API can auto-determine the content-type if the upload is made by passing a reference to a File instead of an InputStream.

The current version of the PR takes advantage of that.
I'm keeping the ContentTypeResolver in the core module so that if other implementations need it, it is already available.

@gkatzioura
Copy link
Owner

Hi @Pitxyoki
I merged your other pull and is out there version 2.1.
I will check this one and get back to you

@Pitxyoki
Copy link
Contributor Author

Pitxyoki commented Jul 19, 2019

Hi @Pitxyoki
I merged your other pull and is out there version 2.1.
I will check this one and get back to you

Hi,
I was just checking and apparently that other PR didn't make it to 2.1. It appears it was merged to the master branch but not to 2.1 and then 2.1 was tagged and released.
Let's hope everything will be included in the next version. :-)

@DmitryKosianov
Copy link

DmitryKosianov commented Oct 29, 2019

Hi,
Are you going to merge it to the master or any release? It is pretty important update as for me. I'm using plugin version 2.3 and it still produce Content-type: application/octet-stream
just because new FileInputStream(file) is created
Hope it will be included in some nearest update

@ayozemr
Copy link

ayozemr commented Nov 13, 2020

Hello! I am having problems to upload some generated docs as they are uploaded as octet-stream so index.html is downloaded instead of rendered.

Will this be released? Thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants