Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle humans spamming shutter or focus buttons. #64

Conversation

gkoh
Copy link
Owner

@gkoh gkoh commented Feb 28, 2024

The latency for BLE comms can easily exceed any human click speed. If this happens, we lose button events.

Handle this by forcing an M5.Update() immediately after sending a command to the camera.

Whilst here:

  • change the loop semantic (coz I can)
  • handle the shutter control back button without conditional compilation
    • let the M5Unified library work out if the buttons actually exist

The latency for BLE comms can easily exceed any human click speed.
If this happens, we lose button events.

Handle this by forcing an M5.Update() immediately after sending a command to the camera.

Whilst here:
- change the loop semantic (coz I can)
- handle the shutter control back button without conditional compilation
  - let the M5Unified library work out if the buttons actually exist
@gkoh gkoh self-assigned this Feb 28, 2024
@gkoh gkoh linked an issue Feb 28, 2024 that may be closed by this pull request
@gkoh gkoh added this to the v2.0.0 milestone Feb 28, 2024
@gkoh gkoh merged commit 26143b7 into master Feb 29, 2024
6 checks passed
@gkoh gkoh deleted the 63-quickly-pressing-buttons-in-shooting-mode-causes-functions-to-get-stuck-on branch February 29, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickly pressing buttons in shooting mode causes functions to get stuck on
1 participant