Enable installation via HACS #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 26, 2021 17:14
Restructure the repository to implement HACS requirements. Changes ======= - Move the integration under the correct `custom_components repository`. - Update manifest.json to include the required attributes for integrations. - Create HACS manifest file - hacs.json. - Update README.md to include HACS installation instructions.
Validate the repository against: - HACS integrations requirements (https://github.com/hacs/action) - Home Assistant's Hassfest validator (https://developers.home-assistant.io/blog/2020/04/16/hassfest/) The `brands` validation is initially ignored as Grohe Sense is not yet added to https://github.com/home-assistant/brands
|
If you accept this PR, I would obviously be happy to help with the next steps to get it added to HACS default repositories! |
|
👍👍👍 |
|
Thanks for working on this, I have emailed the repo owner today and hopefully they will start accepting PRs |
|
I made a pull request today with a suggestion to change from mbar to bar. Also suggested the version change in manifest.json without realizing that it was part of your pull request already. Have you been able to get hold of Gunnar Kreitz? |
|
Looks like this repo is probably stale now? I'd love HACS support for this though. Has anyone considered a fork yet and maintain it? I'd be happy to assist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable installation via HACS to make the process significantly easier and to enable easy updates and uninstall.
Changes
manifest.jsonto add all attributes required for integrations.hacs.jsonmanifest file.README.mdto document installation through HACS.Other changes to the repository/process required
manifest.jsonand a new Github release should be created.Further actions to publish to HACS repository
brandscheck in HACS Github action should be re-enabled.gkreitz/homeassistant-grohe_senseto HACS default integrationRelevant documentation