Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve android native structure #29

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

gladiuscode
Copy link
Owner

This PR aims to improve the current android native code structure to align it to the latest Turbo Modules guide.

So I've implemented the following changes:

  • OrientationDirectoryImpl has been renamed to OrientationDirectorModuleImpl;
  • Both newArch and oldArch Specs have been updated to classes that init the actual implementation and clearly
    separate the required boilerplate: either @ReactMethod or override;

@gladiuscode gladiuscode added enhancement New feature or request Android Android only labels Oct 11, 2024
@gladiuscode gladiuscode self-assigned this Oct 11, 2024
@gladiuscode gladiuscode marked this pull request as draft October 11, 2024 17:54
@gladiuscode gladiuscode marked this pull request as ready for review October 11, 2024 21:45
@gladiuscode gladiuscode merged commit 890a3d3 into main Oct 11, 2024
5 checks passed
@gladiuscode gladiuscode deleted the feature/improve-android-native-structure branch October 11, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android only enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant