Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-460: update notebooks inplace when running nox -s examples #461

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Saransh-cpp
Copy link
Member

nox -s examples now updates the notebooks inplace.

Closes: #460

@Saransh-cpp Saransh-cpp added bug Something isn't working infrastructure Project infrastructure: dev tools, packaging, etc. labels Nov 28, 2024
@Saransh-cpp Saransh-cpp self-assigned this Nov 28, 2024
@ntessore
Copy link
Collaborator

Yeah, that's on me -- you had it right first time when you executed the notebooks to generate the HTML. If we don't want to execute twice, the first execution obviously has to have side effects :)

Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddyroddy paddyroddy merged commit 05c7700 into main Nov 28, 2024
17 checks passed
@paddyroddy paddyroddy deleted the saransh/inplace branch November 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nox is missing --inplace so HTML artefacts never change
3 participants