Add CMake modules to generate VSCode Launch and Settings files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinjaenicke
requested changes
Nov 13, 2024
devinjaenicke
approved these changes
Nov 14, 2024
devinjaenicke
requested changes
Nov 14, 2024
lukewelchGB
reviewed
Nov 15, 2024
| @@ -74,7 +77,7 @@ project(${PROJECT_NAME} VERSION 1.0 LANGUAGES C) | |||
|
|
|||
| # Set the C standard and executable suffix | |||
| set(CMAKE_EXECUTABLE_SUFFIX ".elf") | |||
| set(CMAKE_C_STANDARD 11) | |||
| set(CMAKE_C_STANDARD 99) | |||
There was a problem hiding this comment.
Why C 99 instead of C 2011 or C 2018?
There was a problem hiding this comment.
@lukewelchGB Current flags (flags.cmake) are using -std=gnu99 so setting CMake to be in parity.
…e target automatically
|
@devinjaenicke @lukewelchGB please note I snuck another commit in on you ( |
devinjaenicke
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Pre-Flight Checklist
mainbranch), did you increment/set the version inversion.haccordingly?What issues does this close? (The keyword
closesfollowed by a #ISSUE_NUMBER will automatically close the issue when this PR is completed. i.ecloses #10)