Improve resolution error messages #3640
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocavalieri
force-pushed
the
constraints
branch
2 times, most recently
from
e358dbf to
04a451a
Compare
giacomocavalieri
force-pushed
the
constraints
branch
from
f17c3ff to
308b2a9
Compare
giacomocavalieri
force-pushed
the
constraints
branch
from
308b2a9 to
e3c8a71
Compare
|
Hey hey Jak! Is this branch still wanted? |
|
Oops I haven't worked on this for quite a while but I'd say yeah it's very much wanted. I'll have to go through the new version resolving library's api to implement this, it might be a challenging piece of work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve some messages displayed if version resolution fails.
This only works in a limited case and keeps defaulting to the current error message; solving the problem in the most general way possible seems a really hard problem so I think we could try doing this and keep on improving incrementally as we identify and handle recurring failure reasons.