Use decision trees for code generation on the js target #4382
+3,087
−2,448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocavalieri
force-pushed
the
fix-3969
branch
from
8fbd187 to
80d3407
Compare
| Ok(SizedBitArraySegmentDetails { size, size_value }) | ||
| } | ||
|
|
||
| pub(crate) fn guard(&mut self, guard: &'a TypedClauseGuard) -> Output<'a> { |
There was a problem hiding this comment.
All the code here up to line ~1900 is basically moved as-is from the pattern module where it was previously
|
Please give PRs titles, just a number means folks have to look them up to know what this is |
|
Oops my mistake! |
giacomocavalieri
changed the title
include compiled case in result
The decision tree would have two different kinds of switches, implementing code generation I went over this code again and realised we could represent it using a single variant for both infinite and exhaustive switches: at the end of the day the both still need a "fallback" branch that will match no matter what. So I thought it would make more sense to reconcile the two things in a single variant.
With this change code generation for pattern variables is smarter and avoids doing lots of repeated work always recomputing the value of a pattern variable. Instead, a pattern variable is now bound in scope as soon as a check needs it.
I think a regular match is easier to read than the `!matches!(...)` macro
giacomocavalieri
force-pushed
the
fix-3969
branch
from
78a54d0 to
7daffc0
Compare
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3969 and closes #4221
This is still a WIP as I haven't taken care of bit array patterns yet, but it's ready for everything else if anyone fancies giving this a look in the meantime.
What's missing: