Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Make request.get_headers fully case insensitive #54

Closed
wants to merge 5 commits into from
Closed

(fix): Make request.get_headers fully case insensitive #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd73d56
make get_headers fully case insensitive
dmmulroy Mar 19, 2024
c266652
use
dmmulroy Mar 19, 2024
ebd05d6
PR feedback
dmmulroy Mar 19, 2024
fa10f49
format
dmmulroy Mar 19, 2024
39096af
add more test cases
dmmulroy Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/gleam/http.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,7 @@ fn parse_headers_after_prelude(
// compiler support this.

use <- bool.guard(
when: dsize
< required_size,
when: dsize < required_size,
return: more_please_headers(parse_headers_after_prelude(_, boundary), data),
)

Expand Down
3 changes: 1 addition & 2 deletions src/gleam/http/cookie.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ pub fn defaults(scheme: Scheme) {
max_age: option.None,
domain: option.None,
path: option.Some("/"),
secure: scheme
== http.Https,
secure: scheme == http.Https,
http_only: True,
same_site: Some(Lax),
)
Expand Down
8 changes: 7 additions & 1 deletion src/gleam/http/request.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,13 @@ pub fn from_uri(uri: Uri) -> Result(Request(String), Nil) {
/// If the request does not have that header then `Error(Nil)` is returned.
///
pub fn get_header(request: Request(body), key: String) -> Result(String, Nil) {
list.key_find(request.headers, string.lowercase(key))
let lowercased_key = string.lowercase(key)
use #(_, value) <- result.try(
list.find(request.headers, fn(header) {
string.lowercase(header.0) == lowercased_key
}),
)
Ok(value)
}

/// Set the header with the given value under the given header key.
Expand Down
63 changes: 63 additions & 0 deletions test/gleam/http/request_test.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,69 @@ pub fn get_req_header_test() {
|> should.equal(Error(Nil))
}

pub fn get_req_case_insensitive_header_test() {
let make_request = fn(headers) {
Request(
method: http.Get,
headers: headers,
body: Nil,
scheme: http.Https,
host: "example.com",
port: None,
path: "/",
query: None,
)
}

// Test lowercase key -> uppercase header
let header_key = "gleam"
let request = make_request([#("GLEAM", "awesome")])

request
|> request.get_header(header_key)
|> should.equal(Ok("awesome"))

// Test uppercase key -> uppercase header
let header_key = "GLEAM"
let request = make_request([#("GLEAM", "awesome")])

request
|> request.get_header(header_key)
|> should.equal(Ok("awesome"))

// Test uppercase key -> lowercase header
let header_key = "GLEAM"
let request = make_request([#("gleam", "awesome")])

request
|> request.get_header(header_key)
|> should.equal(Ok("awesome"))

// Test random cased key -> lowercase header
let header_key = "GlEaM"
let request = make_request([#("gleam", "awesome")])

request
|> request.get_header(header_key)
|> should.equal(Ok("awesome"))

// Test uppercase key -> random cased header
let header_key = "GLEAM"
let request = make_request([#("gLeAm", "awesome")])

request
|> request.get_header(header_key)
|> should.equal(Ok("awesome"))

// Test random cased key -> random cased header
let header_key = "GlEaM"
let request = make_request([#("gLeAm", "awesome")])

request
|> request.get_header(header_key)
|> should.equal(Ok("awesome"))
}

pub fn set_req_body_test() {
let body =
"<html>
Expand Down
Loading