Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm macos + linux by using the upcoming github m1 host #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CGDogan
Copy link

@CGDogan CGDogan commented Dec 14, 2023

  • Building for mac is easy
  • To build for linux, use docker likewise. manylinux_2010 doesn't have an arm image published but manylinux_2014 does have an arm image
  • I propose sticking to v1.2.X for now. If you do update to v3.X, you would need to remove all the previous shared library builds, (because despite the java api for turbojpeg hasn't changed, the internal connection inside turbojpeg between its exposed API and the shared library has changed), hence needing to drop ppc, s390x builds, needing a major version bump for bioformats. But if you compile for 1.2.X, you can add these shared libraries to the current bioformats without needing to remove the old ones, and computers with these old architectures would continue to work.
  • You can test this pull request now before GitHub has free public runners (as I do here: https://github.com/CGDogan/libjpeg-turbo-java/actions/runs/7199609084/job/19611649514). On an arm mac with Docker installed, you go to glencoesoftware/libjpeg-turbo-java settings, go to runners, download the macos runner, run config.sh, run ./run.sh, then this pull request will be tested on your computer automatically.

To switch to GitHub public runners (to check (?) is it ready github/roadmap#819), a few little considerations:

  • I replaced the expected mkdir build with rm -rf build && mkdir build, because it seems that the github runner on my computer doesn't delete the previous build files!
  • We wont't know it now if the build-dependencies step requires some additional dependencies, since they might be already installed on my computer, but that's unlikely.
  • Once github has the public runners, I might need to add a workflow step to install docker

@CGDogan CGDogan changed the title arm build scripts arm macos + linux by using the upcoming github m1 host Dec 14, 2023
@CGDogan CGDogan closed this Aug 5, 2024
@CGDogan CGDogan reopened this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant