Allow the PixelsService to be runtime configured #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the micro-service PixelsService subclass by the upstream com.glencoesoftware.omero.zarr.ZarrPixelsService
Inject the NoopQueryImpl from omero-ms-core in the ZarrPixelsService constructor
kkoz
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of the work on glencoesoftware/omero-zarr-pixel-buffer#5 and glencoesoftware/omero-ms-core#31, this makes the necessary adjustments in the micro-service to make the pixels service configurable at runtime
omero-zarr-pixel-bufferandomero-ms-corePixelsServicesubclass is removed from this repository and replaced bycom.glencoesoftware.omero.zarr.ZarrPixelsServicewhich should now include all the require logicNoopQueryImplclass should be injected into the constructor via Spring.omero.pixeldata.pixels_serviceset toZarrPixelsServiceby default is added to the configurationWith these changes, it should be possible to extend the logic by subclassing
ZarrPixelsService, defining a Spring configuration underblitz/*PixelBuffer.xmlwith a named bean for the new pixel service, add the new JAR to the libraries and update the classpath and changeomero.pixeldata.pixels_servicein the configuration to use the new bean name.