EncryptedInputFiles and manual_glidein_submit review: changelog and typo

glideinWMS · Aug 17, 2023 · 78850f8 · 78850f8
1 parent 1479970
commit 78850f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,12 +19,15 @@ Changes since the last release
 
 ### Security Related Fixes
 
+-   manual_glidein_submit now correctly sets idtokens in the EncryptedInputFiles (PR #280)
+
 ### Bug Fixes
 
 -   Removed `classad` from requirements.txt. The HTCSS team distributes only the `htcondor` library in PyPI which includes a different version of classad (PR #301)
 -   Fixing Python 3.9 deprecations (`imp`, `getchildren()` in `xml.etree.ElementTree`) (PR #302, PR #303)
 -   Populate missing Entry parameters for ARC CEs submissions (PR #304)
 -   Modified the usage of subprocess module, for building/rebuilding cvmfsexec distributions, only when necessary (PR #309)
+-   manual_glidein_submit now correctly sets idtokens in the EncryptedInputFiles (issue #283, PR#284)
 
 ### Testing / Development
 
@@ -183,7 +186,6 @@ Changes since the last release
 ### Security Related Fixes
 
 ### Bug Fixes
--   manual_glidein_submit now correctly sets idtokens in the EncryptedInputFiles (PR #280)
 
 ### Testing / Development
 

diff --git a/factory/tools/manual_glidein_submit.py b/factory/tools/manual_glidein_submit.py
@@ -214,7 +214,7 @@ def main():
         if not os.path.exists(condortoken_file):
             logging.warning("Cannot find idtoken file %s" % condortoken_file)
         elif not credentials.add_identity_credential("frontend_condortoken", condortoken_file):
-            entry.log.warning(
+            logging.warning(
                 "failed to add frontend_condortoken %s to the identity credentials %s"
                 % (condortoken_file, str(credentials.identity_credentials))
             )