Fixed idtoken error #322
Merged
Fixed idtoken error #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrathaurs
previously requested changes
Jul 21, 2023
…ra decoding that was corrupting idtoken
jwt.encode can accept a string as key, but will encode it in utf-8, not latin-1, causing a different value
this caused the subtle error where the IDTOKENs verification was failing.
I removed the encoding, fixed type notation, and
I added also a note in a comment to avoid future changes to repeat the error:
master_key should be `bytes`. `str` could cause value changes if was decoded not using utf-8.
The manual (https://pyjwt.readthedocs.io/en/stable/api.html) is incorrect to list `str` only.
The source code (https://github.com/jpadilla/pyjwt/blob/72ad55f6d7041ae698dc0790a690804118be50fc/jwt/api_jws.py)
shows `AllowedPrivateKeys | str | bytes` and if it is str, then it is encoded w/ utf-8: value.encode("utf-8")
mambelli
force-pushed
the
v310/fix_token_generation
branch
from
b74afaa
to
edbb531
Compare
namrathaurs
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed writing of cached token as str
and removed in token_util.py extra decoding that was corrupting idtokens and causing the Glidein schedd authentication to fail.
jwt.encode can accept a string as a key, but will encode it in utf-8, not latin-1, causing a different value (corrupted token)