Skip to content

fix: add specifier in package.json to expose all files in ./src #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yxuko
Copy link

@yxuko yxuko commented Apr 29, 2025

Fixes #701. This makes the import "@glidejs/glide/css/glide.core.css" works again.

@ericmorand
Copy link
Contributor

Wouldn't it make the whole set of exported identifiers public, and contractual? Is it desirable considering that it binds them all to a non-breaking changes policy from the moment they become contractual?

Are the maintainers ready for that?

@yxuko
Copy link
Author

yxuko commented Apr 29, 2025

This actually fixes the following error.

ERROR in ./src/scss/bootstrapper.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
HookWebpackError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
Can't find stylesheet to import.
   ╷
32 │ @import '@glidejs/glide/src/assets/sass/glide.core.scss';
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
  src/scss/bootstrapper.scss 32:9  root stylesheet

Same sort of error was faced in #702

@ericmorand
Copy link
Contributor

@yxuko the.problem that you encounter is not coming from glide. It is coming from the SASS loader that you use, that imports SASS files using Node.js module resolution algorithm.

Node.js module resolution specifies how JavaScript modules are imported, and it requires some proper declaration in package.json. But SASS files are not JavaScript modules, they are not bound to Node.js module resolution specification.

The loader that you use is faulty and you should raise the issue to its maintainers, so that they fix the resolution algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "./dist/css/glide.core.min.css" specifier in "@glidejs/glide" package
2 participants