Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft attempt at ingestion using mapping file #24

Merged
merged 21 commits into from
May 29, 2024
Merged

Conversation

pipliggins
Copy link
Collaborator

@pipliggins pipliggins commented May 8, 2024

Reads data into class then back out again

@codecov-commenter

This comment was marked as outdated.

- Reads data into class then back out again, probably not very efficient.
- Not tested with multiple rows of input data
- Can't cope with multiple columns trying to set the same variable (need logic in mapping file for this)
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few minor typos

fhirflat/__init__.py Outdated Show resolved Hide resolved
fhirflat/flat2fhir.py Outdated Show resolved Hide resolved
fhirflat/ingest.py Show resolved Hide resolved
fhirflat/ingest.py Outdated Show resolved Hide resolved
fhirflat/ingest.py Outdated Show resolved Hide resolved
fhirflat/ingest.py Outdated Show resolved Hide resolved
fhirflat/resources/base.py Outdated Show resolved Hide resolved
fhirflat/resources/base.py Outdated Show resolved Hide resolved
fhirflat/resources/base.py Show resolved Hide resolved
fhirflat/ingest.py Outdated Show resolved Hide resolved
@abhidg abhidg linked an issue May 20, 2024 that may be closed by this pull request
@pipliggins pipliggins marked this pull request as ready for review May 22, 2024 15:18
@pipliggins pipliggins requested a review from abhidg May 22, 2024 15:18
fhirflat/flat2fhir.py Show resolved Hide resolved
fhirflat/flat2fhir.py Show resolved Hide resolved
fhirflat/resources/extensions.py Show resolved Hide resolved
@pipliggins
Copy link
Collaborator Author

@abhidg are you happy for me to merge this? Can continue to iteratively improve on a new branch

@abhidg abhidg self-requested a review May 29, 2024 09:23
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pipliggins pipliggins merged commit a029781 into main May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn into Python package
4 participants