Travis update #41
Open
Travis update #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks. It seem like this gem need a bit more love. I decided to upgrade CI a bit and found that there is an incorrect spec and that the gem doesn't work with AR dirty since Rails 5. The only way to fix it for Rails >= 5.1 is to define an actual attribute with the attributes. But this leads to some confusing results. First of all, all the globalize-accessors attributes are now visible in the entity inspection. Secondly, they are all nils when the entity is loaded from the DB.
So we either accept this weird behavior or exclude globalize accessors from dirty tracking officially. I would do the latter. WDYT?