Avoid interrupt inflight requests after a new socket connect failed #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @carter2000, much appreciated. |
tadukurow
reviewed
May 10, 2017
server.go
Outdated
| server.close(true) | ||
| } | ||
|
|
||
| func (server *mongoServer) close(idle bool) { |
There was a problem hiding this comment.
func (server *mongoServer) close(waitForIdle bool)
There was a problem hiding this comment.
thanks, I have changed it as you suggest.
brknstrngz
reviewed
May 11, 2017
| @@ -316,6 +320,19 @@ func (socket *mongoSocket) Close() { | |||
| socket.kill(errors.New("Closed explicitly"), false) | |||
| } | |||
|
|
|||
szank
approved these changes
May 11, 2017
|
Thanks @carter2000 - we'll be testing a build of this and then we'll merge it into master. Cheers! |
Merged
babygoat
added a commit
to babygoat/go-api
that referenced
this pull request
Jul 16, 2021
This patch updates the outdated mgo package to the community version github.com/globalsign/mgo to fix the issue that the mgo session cannot be used after the primary node shutdown and re-elected. Related issue: globalsign/mgo#5
babygoat
added a commit
to babygoat/go-api
that referenced
this pull request
Jul 16, 2021
This patch updates the outdated mgo package to the community version github.com/globalsign/mgo to fix the issue that the mgo session cannot be used after the primary node shutdown and re-elected. Related issue: globalsign/mgo#5
babygoat
added a commit
to babygoat/go-api
that referenced
this pull request
Jul 21, 2021
This patch updates the outdated mgo package to the community version github.com/globalsign/mgo to fix the issue that the mgo session cannot be used after the primary node shutdown and re-elected. Related issue: globalsign/mgo#5
babygoat
added a commit
to babygoat/go-api
that referenced
this pull request
Jul 21, 2021
This patch updates the outdated mgo package to the community version github.com/globalsign/mgo to fix the issue that the mgo session cannot be used after the primary node shutdown and re-elected. Related issue: globalsign/mgo#5
libi
pushed a commit
to libi/mgo
that referenced
this pull request
Dec 1, 2022
Avoid interrupt inflight requests after a new socket connect failed Thanks to @carter2000
JosephYeh26
added a commit
to JosephYeh26/go-twreport-api
that referenced
this pull request
Apr 23, 2024
This patch updates the outdated mgo package to the community version github.com/globalsign/mgo to fix the issue that the mgo session cannot be used after the primary node shutdown and re-elected. Related issue: globalsign/mgo#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go-mgo#437