-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: Precise spacing #14
Open
MojtabaHs
wants to merge
5
commits into
globulus:main
Choose a base branch
from
MojtabaHs:feat/percise-spacing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MojtabaHs
force-pushed
the
feat/percise-spacing
branch
from
September 22, 2024 18:35
eef0614
to
d7d92fa
Compare
MojtabaHs
force-pushed
the
feat/percise-spacing
branch
from
September 30, 2024 11:38
79843ad
to
d7d92fa
Compare
…unintended horizontal paddings
…intended vertical paddings
MojtabaHs
force-pushed
the
feat/percise-spacing
branch
from
September 30, 2024 11:39
d7d92fa
to
398a7cd
Compare
It seems like the ZStack content does not respect the container size. I will take a look later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code used padding to simulate spacing, which caused 3 main issues:
You can notice all of these issues in the following example image
Before this PR (With spacing of
4
)After this PR (With spacing of
8
)This PR addresses the problem by applying the correct spacing, ensuring that the spacing is separate from the padding:
Additionally, I updated the default spacing from
4
to8
to better align with the original design intent.