feat(Authorization): AuthorizationManager enhancements.
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbottigliero
force-pushed
the
feat-AuthorizationManager-prompt
branch
3 times, most recently
from
9a7e437
to
de296a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 99.05% 99.06% +0.01%
==========================================
Files 70 70
Lines 1168 1182 +14
Branches 179 181 +2
==========================================
+ Hits 1157 1171 +14
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jbottigliero
force-pushed
the
feat-AuthorizationManager-prompt
branch
2 times, most recently
from
3605d65
to
bd0ce30
Compare
jbottigliero
changed the title
AuthorizationManager enhancements.AuthorizationManager enhancements.
jbottigliero
requested review from
theroncross,
becca-palmer and
jakeglobus
feat: Adds `prompt` method to `AuthorizationManager` - allows prompting for consent **without** reseting configured authorization context. feat: Tokens managed by an `AuthorizationManager` will now be stored as a `StoredToken` type, which will include a `__metadata` property in addition to the raw `Token`. The `__metadata` will contain information about the creation and expiration time of the token allowing for improved refresh functionality. feat: Adds `isTokenExpired` method for determining whether or not a stored token is expired.
jbottigliero
force-pushed
the
feat-AuthorizationManager-prompt
branch
from
bd0ce30
to
26d9792
Compare
jakeglobus
approved these changes
Sep 23, 2024
theroncross
approved these changes
Sep 24, 2024
| /* eslint-disable no-underscore-dangle */ | ||
| return token && token.__metadata?.expires | ||
| ? Date.now() + augment >= token.__metadata.expires | ||
| : true; |
There was a problem hiding this comment.
Is the idea of having a fallback to true here to replace any old tokens that didn't get set with an expires value?
There was a problem hiding this comment.
Yeah, although thinking about it a bit more, I think I'm going to change the signature to true | false | undefined and just let the caller decide what to do; In our applications, we'll likely do a refresh in that case.
jbottigliero
force-pushed
the
feat-AuthorizationManager-prompt
branch
from
aa8f059
to
f69bad3
Compare
jbottigliero
pushed a commit
that referenced
this pull request
Sep 24, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.0](v4.2.0...v4.3.0) (2024-09-24) ### Features * **Authorization:** `AuthorizationManager` enhancements. ([#310](#310)) ([644c263](644c263)) ### Bug Fixes * **Search, Typescript:** updates return type for `search.index.getAll` and exports service types. ([#306](#306)) ([7fcebbe](7fcebbe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Adds
promptmethod toAuthorizationManager- allows prompting for consent without reseting configured authorization context.feat: Tokens managed by an
AuthorizationManagerwill now be stored as aStoredTokentype, which will include a__metadataproperty in addition to the rawToken. The__metadatawill contain information about the creation and expiration time of the token allowing for improved refresh functionality.feat: Adds
isTokenExpiredmethod for determining whether or not a stored token is expired.