Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access project from job #808

Merged
merged 11 commits into from
Aug 30, 2022
Merged

Access project from job #808

merged 11 commits into from
Aug 30, 2022

Conversation

AlainKadar
Copy link
Contributor

@AlainKadar AlainKadar commented Aug 10, 2022

Description

Users can access the project which a job belongs to from the job object

Motivation and Context

Resolves #423

Checklist:

@AlainKadar AlainKadar requested a review from bdice August 10, 2022 20:21
@AlainKadar AlainKadar requested review from a team as code owners August 10, 2022 20:21
@AlainKadar AlainKadar requested review from iblanco11981870 and removed request for a team August 10, 2022 20:21
@AlainKadar AlainKadar changed the title First pass Access project from job Aug 10, 2022
@AlainKadar AlainKadar mentioned this pull request Aug 10, 2022
6 tasks
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for docstrings, otherwise LGTM.

signac/contrib/job.py Outdated Show resolved Hide resolved
tests/test_job.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #808 (5783d30) into next (52ff017) will decrease coverage by 1.28%.
The diff coverage is 78.89%.

@@            Coverage Diff             @@
##             next     #808      +/-   ##
==========================================
- Coverage   86.32%   85.03%   -1.29%     
==========================================
  Files          51       54       +3     
  Lines        4687     4685       -2     
  Branches     1022     1012      -10     
==========================================
- Hits         4046     3984      -62     
- Misses        456      522      +66     
+ Partials      185      179       -6     
Impacted Files Coverage Δ
signac/common/deprecation/__init__.py 0.00% <0.00%> (ø)
signac/common/errors.py 100.00% <ø> (ø)
signac/contrib/__init__.py 100.00% <ø> (ø)
signac/contrib/errors.py 94.11% <ø> (ø)
signac/synced_collections/_caching.py 0.00% <0.00%> (ø)
..._collections/buffers/memory_buffered_collection.py 100.00% <ø> (ø)
...ignac/synced_collections/data_types/synced_list.py 85.98% <ø> (ø)
signac/synced_collections/validators.py 91.48% <ø> (ø)
signac/testing.py 100.00% <ø> (ø)
signac/contrib/import_export.py 77.24% <71.42%> (-0.18%) ⬇️
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@iblanco11981870 iblanco11981870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

tests/test_job.py Outdated Show resolved Hide resolved
@bdice
Copy link
Member

bdice commented Aug 26, 2022

@AlainKadar Before this can be merged, we need to update the changelog and add you to the contributors list, following the PR checklist.

Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdice bdice merged commit c7a233a into next Aug 30, 2022
@bdice bdice deleted the 423-project-from-job branch August 30, 2022 18:24
@vyasr vyasr mentioned this pull request Aug 30, 2022
bdice added a commit that referenced this pull request Oct 7, 2022
* First pass

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Initialize job

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tests/test_job.py

* Add test for custom Project subclass.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix test.

* Update changelog and contributors

* Formatting

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hardik Ojha <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
bdice added a commit that referenced this pull request Oct 27, 2022
* First pass

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Initialize job

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tests/test_job.py

* Add test for custom Project subclass.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix test.

* Update changelog and contributors

* Formatting

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hardik Ojha <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
vyasr pushed a commit that referenced this pull request Oct 30, 2022
* First pass

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Initialize job

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tests/test_job.py

* Add test for custom Project subclass.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix test.

* Update changelog and contributors

* Formatting

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hardik Ojha <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants