-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the config module internal #877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
==========================================
+ Coverage 86.51% 86.61% +0.10%
==========================================
Files 39 41 +2
Lines 4522 4580 +58
Branches 901 901
==========================================
+ Hits 3912 3967 +55
- Misses 429 432 +3
Partials 181 181
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one comment about our import in signac/project.py
.
… public." This reverts commit f94a2a7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
This PR moves signac.config to signac._config, reflecting that all its members are private. To simplify its usage, all the functions that it contains have had their leading underscores removed since they are now redundant.
Motivation and Context
Resolves #874
Checklist: