-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of $not expression on command line #970
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 85.65% 85.71% +0.06%
==========================================
Files 20 20
Lines 3464 3466 +2
Branches 759 760 +1
==========================================
+ Hits 2967 2971 +4
+ Misses 338 337 -1
+ Partials 159 158 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see test_shell
avoid importing from test_find_command_line_interface
, but I won't block this PR on that.
Description
test_shell.py
test_find_command_line_interface.py
that does not properly test the code path but I left a todo for now.Motivation and Context
The
$not
expression was broken on the command line. I noticed this while working on glotzerlab/signac-docs#199signac was inserting
sp.
prefixes before the operatorThe function
filterparse._add_prefix
does the inserting, which later triggered an error in_search_indexer._find_expression
. This code path wasn't tested.Checklist: