-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pandas from 2.1.4 to 2.2.0 #972
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
+ Coverage 85.51% 85.71% +0.20%
==========================================
Files 20 20
Lines 3466 3466
Branches 760 760
==========================================
+ Hits 2964 2971 +7
+ Misses 345 337 -8
- Partials 157 158 +1 ☔ View full report in Codecov by Sentry. |
f9138a5
to
6d1356e
Compare
The failing builds are due to a new dependency of pandas
|
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.1.4 to 2.2.0. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v2.1.4...v2.2.0) --- updated-dependencies: - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
6d1356e
to
28241ca
Compare
I would suggest adding this warning to the Line 104 in f9df893
|
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.1.4 to 2.2.0. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v2.1.4...v2.2.0) --- updated-dependencies: - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
28241ca
to
a9ae3e5
Compare
…o dependabot/pip/pandas-2.2.0
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@bdice do you think we should catch the warning in the functions that use pandas? Or will users of those functions want to know about the new 2nd-order dependency? |
One would hope that pandas will add the requirement as a dependency so that package managers will automatically install pyarrow on upgrade. Users should not have to install pyarrow manually. I don't know what this warning is intended to achieve - additional dependencies are not a breaking change. |
@cbkerr @joaander This issue has more context. pandas-dev/pandas#5446 The primary reservations some have expressed about making pyarrow a required dependency are its effects on the environment size (more than doubling the size of pandas' current dependency tree), Linux distros that don't have pyarrow packages already, etc. If pyarrow is made a required dependency of pandas, then it won't have to be installed manually. In the current release of pandas, pyarrow is optional. No action is required here by signac, except to ignore the warning in signac tests (done in this PR). |
@bdice, understood. The warning is attempting to create volumes of discourse on the topic with the added bonus of breaking all CI checks that depends on pandas. |
Bumps pandas from 2.1.4 to 2.2.0.
Release notes
Sourced from pandas's releases.
Commits
f538741
RLS: 2.2.02fa26fd
Backport PR #56967 on branch 2.2.x (CI: Adjust pyarrow depr warning to accoun...fd3f571
RLS: 2.2.0b070774
Backport PR #56952: DEPR: Make FutureWarning into DeprecationWarning … (#56964)dfd0aed
Backport PR #56896 on branch 2.2.x (DEPS: Add warning if pyarrow is not insta...859c030
Backport PR #56922 on branch 2.2.x (REGR: DatetimeTZDtype from_arrow inte...cc37a13
Backport PR #56949 on branch 2.2.x (CI: avoid FutureWarnings in to_xarray tes...a95029a
Backport PR #56947 on branch 2.2.x (DOC: Set date for 2.2) (#56950)160d7a1
Backport PR #56587 on branch 2.2.x (ENH: support the Arrow PyCapsule Interfac...74fa740
Backport PR #56445: Adjust merge tests for new string option (#56938)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)