Fix(LockedField): prevent purge of lockedField without authorization on the linked object entity #18353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the linked object entity
stonebuzz
requested review from
trasher,
orthagh,
cedric-anne and
AdrienClairembault
|
Seems correct, could you add a test please? |
trasher
approved these changes
Nov 20, 2024
cedric-anne
reviewed
Nov 20, 2024
Co-authored-by: Cédric Anne <[email protected]>
AdrienClairembault
approved these changes
Nov 20, 2024
cedric-anne
reviewed
Nov 21, 2024
cedric-anne
requested changes
Nov 21, 2024
Comment on lines
+74
to
+80
| if ( | ||
| $item->getFromDB($this->fields['items_id']) //not a global lock | ||
| && $item->isEntityAssign() | ||
| && !Session::haveAccessToEntity($item->getEntityID(), $item->isRecursive()) // no access to main item entity | ||
| ) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
If there is a lack of checks for the purge right, I guess there is the same lack of checks for the creation and the update right. Could you fix that too ?
Comment on lines
+88
to
+96
| $item = new $lock->fields['itemtype'](); | ||
| if ( | ||
| $item->getFromDB($lock->fields['items_id']) //not a global lock | ||
| && $item->isEntityAssign() | ||
| && !Session::haveAccessToEntity($item->getEntityID(), $item->isRecursive()) // no access to main item entity | ||
| ) { | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
The code looks pretty similar to what is done in the canPurgeItem() method. You should probably move it into a private function canAccessItemEntity(string $itemtype, int $items_id): bool method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
GLPI does not respect the current user's permissions when deleting (purging) a
LockedField.This allows a
LockedFieldlinked to an object from another entity to be deleted.I am also questioning the handling of
globalLockedFields.Currently, anyone with the
UPDATEpermission can delete a global lock (with or without thisPR), regardless of the entity, as theLockedFieldobject does not include anentities_id.Screenshots (if appropriate):