Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tabler to v1.0.0 Stable #18874

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cconard96
Copy link
Contributor

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

Upgrade Tabler to v1.0.0 stable. This PR only includes fixes for issues noticed after the upgrade. It doesn't address any potential new features that could be utilized.

@cconard96 cconard96 marked this pull request as draft February 1, 2025 11:36
@orthagh
Copy link
Contributor

orthagh commented Feb 4, 2025

So far, I haven't found any major regressions.
it's not necessarily a bad thing, but everything seems more compact, especially .form-control
It's more a thought than a required change, but removing shadows on inputs may help with clarity.
(A parenthesis about shadows, on the current main branch, but not on 10.0.x, there are doubled on dropdowns input)

More disturbing, the height of .btn-sm buttons is very small. An explicit example here:
image

@cconard96
Copy link
Contributor Author

cconard96 commented Feb 4, 2025

Something not strictly from the stable v1 release, but it is getting more annoying is the color management.

Bootstrap/Tabler sometimes use SASS variables to refer to colors which is why sometimes it uses blue as the primary color and we have to make custom CSS rules to fix it.

They also don't really account for more than two themes. Their own light theme and their own dark theme. Custom themes that can be light or dark with different colors don't always work well.

I think there is going to be more need for custom CSS to fix color usages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants