Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes the style of the reasons for waiting completed #18939

Draft
wants to merge 3 commits into
base: 10.0/bugfixes
Choose a base branch
from
Draft

Changes the style of the reasons for waiting completed #18939

wants to merge 3 commits into from
+26 −3

Conversation

MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Feb 6, 2025 •
edited
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It's fixes !36212
  • This PR changes the style once the wait reasons are more active

Screenshots (if appropriate):

Pending Reason Done
Capture d’écran du 2025-02-06 16-14-12

Pending Reason Active
Capture d’écran du 2025-02-06 16-14-49

@MyvTsv MyvTsv requested review from stonebuzz and Rom1-B February 6, 2025 15:16
@MyvTsv MyvTsv self-assigned this Feb 6, 2025
Rom1-B
Rom1-B suggested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the number of the corresponding ticket in the description of the PR.

templates/components/itilobject/timeline/pending_reasons_messages.html.twig Show resolved Hide resolved
@cedric-anne cedric-anne requested a review from Rom1-B February 10, 2025 15:30
@Rom1-B Rom1-B added this to the 10.0.19 milestone Feb 10, 2025
@cedric-anne
Copy link
Member

I put back this PR to draft. Waiting a couple of days before merging 10.0.19 changes.

@cedric-anne cedric-anne marked this pull request as draft February 12, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@stonebuzz stonebuzz Awaiting requested review from stonebuzz

At least 1 approving review is required to merge this pull request.

Assignees

@MyvTsv MyvTsv

Labels
None yet
Projects
None yet
Milestone
10.0.19
Development

Successfully merging this pull request may close these issues.
3 participants
@MyvTsv @cedric-anne @Rom1-B