Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert memory with unit to proper int #131

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

trasher
Copy link
Collaborator

@trasher trasher commented Feb 6, 2024

I saw the issue from a long time existing XML file with a unit in virtual machine memory:

    <VIRTUALMACHINES>
      <MEMORY>2048MB</MEMORY>
      ...
    </VIRTUALMACHINES>

The above is converted to null, while vm/memory must be an integer.

@trasher trasher force-pushed the feature/fix/unitmem branch from 2995cfa to 926d820 Compare February 6, 2024 13:09
@trasher trasher merged commit db40b22 into master Feb 6, 2024
5 checks passed
@trasher trasher deleted the feature/fix/unitmem branch February 6, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants