Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consistency checks to geomean and normalized mean calculation methods #13

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

mestinso
Copy link
Contributor

@mestinso mestinso commented Mar 4, 2017

No description provided.

@gluc
Copy link
Owner

gluc commented Mar 5, 2017

Thx, makes sense, but there are two test cases that now fail:

2. Failure: Analyze Identity (@test-Analyze.R#12) ------------------------------
  names(df) not equal to c(...).
  Lengths differ: 9 vs 8
  
  
  testthat results ================================================================
  OK: 466 SKIPPED: 0 FAILED: 2
  1. Failure: Analyze Identity (@test-Analyze.R#11) 
  2. Failure: Analyze Identity (@test-Analyze.R#12) 
  
  Error: testthat unit tests failed
  Execution halted
* DONE

Now handles consistency checks for geometric mean calculation.
@gluc
Copy link
Owner

gluc commented Mar 13, 2017

There is still a warning in the build:

checking for code/documentation mismatches ... WARNING
Codoc mismatches from documentation object 'PrioritiesFromPairwiseMatrixEigenvalues':
PrioritiesFromPairwiseMatrixMeanNormalization
  Code: function(mat, allowedConsistency = 1)
  Docs: function(mat)
  Argument names in code not in docs:
    allowedConsistency
PrioritiesFromPairwiseMatrixGeometricMean
  Code: function(mat, allowedConsistency = 1)
  Docs: function(mat)
  Argument names in code not in docs:
    allowedConsistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants