Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyvista dependency and update export options #35

Merged
merged 84 commits into from
Aug 6, 2024
Merged

Remove pyvista dependency and update export options #35

merged 84 commits into from
Aug 6, 2024

Conversation

Carifio24
Copy link
Member

This PR removes the package's dependency on pyvista, which resolves #32. This involves a large refactor of the package and involves a few major changes:

  • Remove support for exporting to OBJ files
  • Add support for exporting to USD files
  • Add voxel-based export (in addition to isosurface method) for volume layers
  • Add meshoptimizer as a glTF compression option
  • Use registry-based system to add layer export methods
  • Update the export dialog to allow for selecting a different export method (if available) for each layer
  • Improve sizing of spheres for scatter layers

Carifio24 added 30 commits July 7, 2024 01:01
@Carifio24
Completed first draft of voxel export.
4e3617c
@Carifio24
Some tinkering with the voxel approach.
dc900d8
@Carifio24
More work on voxel procedure.
c959f0a
@Carifio24
We can now output voxelized glTF models at decent resolution, provide…
7241011 
…d that the object isn't too space-filling.
@Carifio24
Update import location and methods for test function.
67c5c56
@Carifio24
Use correct axes for export.
8702cc0
@Carifio24
Start working on marching cubes idea.
0c4b2f5
@Carifio24
Marching cubes method seems to be working nicely for glTF.
464e0c0
@Carifio24
Add USD implementation.
1c1606b
@Carifio24
Fix issue with triangle min/maxes. Remove lowest isosurface level to …
621ae91 
…remove artifacts.
@Carifio24
Add builder for helping to construct glTF files from multiple layers.
a282c3e
@Carifio24
Have builder class follow builder pattern. Start working on building …
dfc84b2 
…our own glTFs for scatter layers.
@Carifio24
More work on marching cubes for USD.
59824a6
@Carifio24
Start adding point export.
76e6dd8
@Carifio24
Add utility functions for alpha compositing and determining export la…
5015637 
…yers.
@Carifio24
Extend voxel export to work with multiple layers.
2a9357d
@Carifio24
Update voxel export to use GLTF builder.
4453230
@Carifio24
Modify marching cubes to allow multiple layers. Move shape calculatio…
db4f48b 
…ns into separate files and add cylinder and cone.
@Carifio24
Fix cylinder and circular cone functions.
188225c
@Carifio24
Allow not specifying a material for a mesh.
e9b8755
@Carifio24
Remove unused import.
d13c634
@Carifio24
Use tuple in offset_triangles for consistency.
a7b2f21
@Carifio24
WIP: More work on adding direct glTF scatter export.
51c52a1
@Carifio24
Make isosurface opacities go from 0.5 -> 1 times the layer opacity fo…
a572a30 
…r USD.
@Carifio24
Add missing import.
3a261e7
@Carifio24
Update mesh method in glTF builder.
ffaf3de
@Carifio24
Adjust data axes for glTF convention.
435f76f
@Carifio24
Adjust sphere radii for linear size in glTF.
cdd91f2
@Carifio24
Apply mask to cmap attribute to get correct color values.
ff5a25a
@Carifio24
Remove redundant triangle row in sphere triangulation.
8fddd23
Carifio24 added 20 commits August 3, 2024 03:01
@Carifio24
Work on hooking up generic method for exporting based on layer options.
9648094
@Carifio24
Export dialog UI is now working.
54bee56
@Carifio24
The export method works, but state values aren't being retained in th…
6bbb03c 
…e dialog.
@Carifio24
Some more work on setting up the export dialog.
bcd43f5
@Carifio24
Fix setup of the export dialog state dictionary.
b7312d9
@Carifio24
Add separator between layer and overall options in export dialog. Bri…
e19c62d 
…ng isosurface points into clip space.
@Carifio24
Remove pyvista export functionality.
17a9815
@Carifio24
Update layout of export dialog.
76dd301
@Carifio24
Use correct bounds type based on viewer in export tool. Fix mistake i…
d9ba6c5 
…n scatter sizing. Assorted other improvements.
@Carifio24
Remove some debugging print statements.
354075e
@Carifio24
Codestyle fixes and remove more old code.
033942e
@Carifio24
Fix glTF marching cube points.
0cb5351
@Carifio24
Do the same for USD marching cube points.
98f62b8
@Carifio24
Fix incorrect indices in glTF voxel output.
0e5a414
@Carifio24
Voxel indices aren't quite right yet.
26a1f57
@Carifio24
Fix voxel indices.
ebc1f65
@Carifio24
Remove pyvista from setup.py.
0a6aad2
@Carifio24
Fix issue with export dialog.
2da4cc1
@Carifio24
Fix issue with labels for subsets that appear multiple times in a vie…
cc9bffc 
…wer.
@Carifio24
Restore use of exporting dialog and make codestyle fixes.
6293ddb
@Carifio24 Carifio24 changed the base branch from remove-pyvista to master August 6, 2024 13:57
@Carifio24 Carifio24 merged commit d83f5f4 into glue-viz:master Aug 6, 2024
3 checks passed
This was referenced Aug 6, 2024
Closed
Merged
Merged
@Carifio24 Carifio24 added dependencies enhancement New feature or request glTF Related to export of glTF/glB files USD Related to export of USD files labels Aug 12, 2024
@Carifio24 Carifio24 deleted the remove-pyvista branch December 13, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies enhancement New feature or request glTF Related to export of glTF/glB files USD Related to export of USD files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore removing PyVista dependency
1 participant
@Carifio24