Guess lat/lon columns for viewer when appropriate #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 69.19% 71.21% +2.02%
==========================================
Files 18 18
Lines 1003 1063 +60
==========================================
+ Hits 694 757 +63
+ Misses 309 306 -3 ☔ View full report in Codecov by Sentry. |
|
Rebased to resolve merge conflicts. |
astrofrog
requested changes
May 13, 2024
|
@astrofrog I've added a couple of tests for this behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #63 and thought that was an interesting idea, so this PR uses the relevant pywwt to resolve #63 by guessing lat/lon columns when appropriate. To me, "when appropriate" means when adding the first data layer to the viewer - if there was already a layer in the viewer, the choice might clash with what's already selected (whether that's from the automatic selection or what the user has selected), and unexpectedly changing the viewer state from what's already there is obviously not ideal.