-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list plugins method and tests #2496
Open
CyclingNinja
wants to merge
6
commits into
glue-viz:main
Choose a base branch
from
CyclingNinja:add_listplugins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cf6c4be
Add list plugins method and tests
CyclingNinja a9beefb
Codestyle modifications
CyclingNinja 8589681
Test adjustments
CyclingNinja fcc2f54
adding available plugins function and test
CyclingNinja 6169782
Complete tests and revert qt_refactor
CyclingNinja 20787f2
Correct tests to plugin count
CyclingNinja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,25 @@ | ||
from unittest.mock import patch | ||
|
||
from glue.main import load_plugins | ||
from glue.main import load_plugins, list_loaded_plugins, list_available_plugins | ||
from glue._plugin_helpers import REQUIRED_PLUGINS | ||
|
||
|
||
def test_load_plugins(capsys): | ||
""" | ||
Test customisable list of plugins load | ||
""" | ||
from glue.logger import logger | ||
|
||
with patch.object(logger, 'info') as info: | ||
load_plugins() | ||
|
||
# plugins = [call[0][0] for call in info.call_args_list if ('succeeded' or 'loaded') in call[0][0]] | ||
plugins = [] | ||
for acall in info.call_args_list: | ||
if ('loaded' or 'succeeded') in acall[0][0]: | ||
plugins.append(acall[0][0].split(' ')[1]) | ||
|
||
assert 'coordinate_helpers' in plugins | ||
|
||
|
||
def test_no_duplicate_loading(capsys): | ||
|
@@ -15,6 +34,35 @@ def test_no_duplicate_loading(capsys): | |
with patch.object(logger, 'info') as info: | ||
load_plugins() | ||
|
||
plugins = [] | ||
for acall in info.call_args_list: | ||
plugins.append(acall[0][0]) | ||
if 'Loading plugin' in acall[0][0]: | ||
assert 'failed' in acall[0][0] | ||
|
||
loaded_plugins = list_loaded_plugins() | ||
assert 'glue.plugins.wcs_autolinking' in loaded_plugins | ||
assert 'glue.core.data_exporters' in loaded_plugins | ||
assert 'glue.plugins.coordinate_helpers' in loaded_plugins | ||
|
||
|
||
def test_list_loaded_plugins(): | ||
""" | ||
Unit test for retrieving the list of currently loaded plugins | ||
""" | ||
load_plugins(require_qt_plugins=False) | ||
plugins = list_loaded_plugins() | ||
assert isinstance(plugins, list) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe you can check that certain plugins are in the list |
||
for test_plugin in REQUIRED_PLUGINS: | ||
assert test_plugin in plugins | ||
|
||
|
||
def test_list_available_plugins(): | ||
""" | ||
Unit test for retrieving the list of currently available plugins | ||
""" | ||
available_plugins = list_available_plugins() | ||
assert isinstance(available_plugins, list) | ||
assert 'glue.plugins.wcs_autolinking' in available_plugins | ||
assert 'glue.core.data_exporters' in available_plugins | ||
assert 'glue.plugins.coordinate_helpers' in available_plugins |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you import these two functions into the top-level of the package? See:
glue/glue/__init__.py
Line 22 in 5e92185