Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: replace np.in1d (deprecated) with np.isin #2503

Merged
merged 1 commit into from
Jul 15, 2024
Merged

MNT: replace np.in1d (deprecated) with np.isin #2503

merged 1 commit into from
Jul 15, 2024

Conversation

neutrinoceros
Copy link
Contributor

This removes about 25 warnings from the test suite
Patch performed with

ruff check --select NPY201 --fix glue

@dhomeier dhomeier added the no-changelog-entry-needed Skipped in Changelog generation label Jul 15, 2024
dhomeier
dhomeier approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@astrofrog astrofrog merged commit 6cb7094 into glue-viz:main Jul 15, 2024
29 checks passed
@neutrinoceros neutrinoceros deleted the numpy2_depr branch July 15, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhomeier dhomeier dhomeier approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed Skipped in Changelog generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neutrinoceros @dhomeier @astrofrog