Remove viewer-specific code from __gluestate__ and __setgluestate__ on base Application class #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s don't - this can happen when reloading sessions
… since it is different between Jupyter and Qt glue
astrofrog
changed the title
astrofrog
force-pushed
the
restore-session
branch
from
7c514bb to
41582d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easier to just code these specifically for Jupyter and Qt since how the viewers are stored is quite different (Qt uses tabs)
This also fixes an issue with restoring colormaps from session files under certain circumstances