Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with derive_more #271

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Nov 25, 2023

This PR simply replaces all manual implementation of Deref and From with the derive_more::{From, Deref}` attribute macros.

The purpose is not to say that this should be done, but it's more so a presentation on how it would look in practice. E.g. making it possibly easier to decide on whether a 44 insertions(+), 497 deletions(-) commit outweighs the con of introducing one more dependency. (All sub-dependencies are already used by serde.) I would be perfectly understanding if this PR gets rejected 😊

(Commit placed on top of #268 because the concept could be applied there as well, not because it strictly depends on it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant