Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Handroll Deserialize implementations for CompletionResponse and CompletionTextEdit #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: Handroll Deserialize implementations for CompletionResponse and CompletionTextEdit #287

wants to merge 1 commit into from

Commits on Jun 12, 2024

  1. perf: Handroll Deserialize implementations for CompletionResponse and… 

    … CompletionTextEdit

In Zed, we've noticed that deserialization of CompletionResponse takes non-trivial amount of time (it takes ~380ms to deserialize a 60MB of JSON). We've attributed it to #[serde(untagged)] and rewrote the Deserialize impls manually, cutting down the time for the same scenario down to 120ms. The impls are actually pretty straightforward, as the types being deserialized have a distinct structure to them which allows us to dispatch to other Deserialize impl on the Visitor level.
    @osiewicz
    osiewicz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7773159 View commit details
    Browse the repository at this point in the history