cli: Support Setting old Volume option names

[aravindavk]

Fixes: #739
Signed-off-by: Aravinda VK [email protected]

[aravindavk]

legacy-volopts.go file generated by parsing glusterd-volume-set.c file. Script used is available here, not added to source tree since this is required only once.

https://gist.github.com/aravindavk/672146cd5b5d050309a78c948f79dc5c

[aravindavk]

@amarts With this patch, volume set works with old option names. But Volinfo will show new names only.

[amarts]

With this patch, volume set works with old option names. But Volinfo will show new names only.

Yes, this is a good start. Lets see with this, how many regressions work, or fails. I am thinking we should do a wrapper function which can deal with compatibility in regression itself.

[prashanthpai]

@amarts With this patch, volume set works with old option names. But Volinfo will show new names only.

We can do reverse mapping of responses back to old names as regression tests look for old names. @aravindavk Is that planned ?

This approach looks good to me as long as it's primary purpose is to re-use existing regression tests. For users, we should strongly encourage using the new names and deprecate the old ones gradually. Please add a deprecated warning when old option names are used.

[atinmu]

+1, I second Prashanth’s opinion.

On Wed, 13 Jun 2018 at 06:57, Prashanth Pai ***@***.***> wrote: @amarts <https://github.com/amarts> With this patch, volume set works with old option names. But Volinfo will show new names only. We can do reverse mapping of responses back to old names as regression tests look for old names. @aravindavk <https://github.com/aravindavk> Is that planned ? This approach looks good to me as long as it's primary purpose is to re-use existing regression tests. For users, we should strongly encourage using the new names and deprecate the old ones gradually. Please add a deprecated warning when old option names are used. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#816 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGp7mBuOzu--Zj7_JwYPe9pRfCMGPmWwks5t8PAYgaJpZM4URJbY> .

-- - Atin (atinm)

[aravindavk]

We can do reverse mapping of responses back to old names as regression tests look for old names. @aravindavk Is that planned ?

This approach looks good to me as long as it's primary purpose is to re-use existing regression tests. For users, we should strongly encourage using the new names and deprecate the old ones gradually. Please add a deprecated warning when old option names are used.

I started this effort to add backward compatibility for Volume options, but now I realized a problem with new names. For example, Self heal daemon is common for disperse/replica, these options are set using replicate.<optname>, but this will add confusion to users.

I have some unanswered questions to proceed on this PR, we can discuss that next week.

[atinmu]

Would this be needed for GCS? I guess the priority can be low as many of the option settings will be done through storage class?

[prashanthpai]

Would this be needed for GCS? I guess the priority can be low as many of the option settings will be done through storage class?

Ack. GCS is a limited and opinionated deployment.