Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fork Lift upgrade of tests #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Another fork Lift upgrade of tests #70

wants to merge 1 commit into from

Conversation

jayunit100
Copy link
Contributor

src/test/java/org/apache/hadoop/fs/test/unit/HcfsMainOperationsBaseTest.java... prefer FSMainOperationsTests where there is a conflict of behavior (3) confiugrable sorting so that testListStatus can behave the old or new wway, by user preference, (4) umask support, so that hadoop umasks are honored
...

All tests now pass, but we will have to review this full commit when the time is right. The main features are

  1. hadoop umask honoring
  2. Configurable sort for ListStatus
  3. Overriding some FileSystemContract methods, where there are conflicts with competing FSMainOperations test implementations.
  4. Imported umask test into Our tests, so that in case we phase out FileSystemContract Tests, we still have umask unit test.
    ...
    0
    Tests run: 50, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.344 sec
    Running org.apache.hadoop.fs.test.unit.HcfsFileSystemContractBaseTest
    Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.348 sec
    Running org.apache.hadoop.fs.test.unit.HcfsFileSystemTest
    Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.117 sec

… to prefer FSMainOperationsTests where there is a conflict of behavior (3) confiugrable sorting so that testListStatus can behave the old or new wway, by user preference, (4) umask support, so that hadoop umasks are honored

public String getScheme(){
return this.NAME.toString();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is getScheme() part of the API? Why is it needed?

@jayunit100
Copy link
Contributor Author

@childsb ~~~~~~~~~~ see below ~~~~~~~~~~~~

$ git status# On branch branch-2.2
nothing to commit, working directory clean

$ cat `find ./ -name FileSystem.java` | grep -A 2 "String getScheme()"

public String getScheme() {
   throw new UnsupportedOperationException("Not implemented by the " + getClass().getSimpleName() + "   
   FileSystem implementation");
}

public String getScheme() {
  return scheme;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants