Codechange: Replace game options' style-breaking if-condition with sw…

…itch.
glx22 · Jan 14, 2024 · 8ca867e · 8ca867e
1 parent 341d022
commit 8ca867e
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/settings_gui.cpp b/src/settings_gui.cpp
@@ -390,9 +390,14 @@ struct GameOptionsWindow : Window {
 		this->LowerWidget(widget);
 		GameOptionsWindow::active_tab = widget;
 
-		int pane = 0;
-		if (widget == WID_GO_TAB_GRAPHICS) pane = 1;
-		else if (widget == WID_GO_TAB_SOUND) pane = 2;
+		int pane;
+		switch (widget) {
+			case WID_GO_TAB_GENERAL: pane = 0; break;
+			case WID_GO_TAB_GRAPHICS: pane = 1; break;
+			case WID_GO_TAB_SOUND: pane = 2; break;
+			default: NOT_REACHED();
+		}
+
 		this->GetWidget<NWidgetStacked>(WID_GO_TAB_SELECTION)->SetDisplayedPlane(pane);
 		this->SetDirty();
 	}