Merge pull request #97 from glycojones/reviewer-comments

Externalise Links
glycojones · Mar 17, 2024 · 71c0022 · 71c0022
2 parents 1ae03f9 + 6b134c8
commit 71c0022
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/webapp/src/layouts/Footer.tsx b/webapp/src/layouts/Footer.tsx
@@ -4,6 +4,8 @@ export default function Footer(): ReactElement {
         <footer className="bg-gray w-full mt-auto">
             <div className="w-full mx-auto max-w-screen-xl p-4 flex items-center justify-center">
                 <span className="text-sm text-primary text-center justify-center dark:text-gray-400">
+                    <p>Spotted an issue? Please email us or <a href="https://github.com/glycojones/privateer/issues/new/choose" target='_blank' > submit a GitHub issue </a>
+                    </p>
                     York Structural Biology Laboratory
                     <br />
                     © 2023-2024 University of York. All Rights Reserved.

diff --git a/webapp/src/layouts/NavBar.tsx b/webapp/src/layouts/NavBar.tsx
@@ -92,7 +92,7 @@ export default function NavBar(): ReactElement {
                     </a>
                 </div>
                 <div className="h-12 w-12 mx-auto my-4 sm:w-12 sm:mt-12 sm:mr-12 flex items-center ">
-                    <a id="github" href={GITHUB_REPO}>
+                    <a id="github" href={GITHUB_REPO} target="_blank">
                         <img
                             className="w-full hover:scale-125 transition-all hidden dark:block"
                             src="/github-mark.png"

diff --git a/webapp/src/modals/Citations/Citations.tsx b/webapp/src/modals/Citations/Citations.tsx
@@ -72,7 +72,7 @@ export default function CitationModal(props: {
                         McNicholas, S. J. & Agirre, J. (2024). Online
                         carbohydrate 3D structure validation with the Privateer
                         web app. Acta Cryst. F80.
-                        https://doi.org/10.1107/S2053230X24000359
+                        <p><a href="https://doi.org/10.1107/S2053230X24000359" target="_blank">https://doi.org/10.1107/S2053230X24000359</a></p>
                     </strong>
                 </div>
 

diff --git a/webapp/src/shared/Information/Information.tsx b/webapp/src/shared/Information/Information.tsx
@@ -89,7 +89,7 @@ export function Information() {
                         <div className="flex flex-col gap-6 justify-center">
                             <span className="text-xl font-body">
                                 <b>Glycomics-Powered Validation</b>
-                                <a href={GLYCOMICS_CITATION}>
+                                <a href={GLYCOMICS_CITATION} target="_blank">
                                     <svg
                                         className="inline pl-2 h-4 transition-all hover:h-5 fill-secondary"
                                         xmlns="http://www.w3.org/2000/svg"
@@ -119,7 +119,7 @@ export function Information() {
                         <div className="flex flex-col gap-6 justify-center">
                             <span className="text-xl font-body">
                                 <b>Linkage Torsion Validation</b>
-                                <a href={TORSIONS_CITATION}>
+                                <a href={TORSIONS_CITATION} target="_blank">
                                     <svg
                                         className="inline pl-2 h-4 transition-all hover:h-5 fill-secondary"
                                         xmlns="http://www.w3.org/2000/svg"