Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to scikit-build-core build system #107

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

Dialpuri
Copy link
Collaborator

@Dialpuri Dialpuri commented Sep 5, 2024

Description

This pull requests changes Privateer's complicated build system into one using scikit-build-core. This change will significantly speed up compilation time, allow editable installs, and make the build system much more maintainable as versions change.

Changes:

  • Change to NucleoFind's scikit-build-core compilation style
  • Remove troublesome privateer-interactions code
  • Removed CCP4SRS dependencies
  • Upgrade to gemmi 0.6.5

Caveats

  • There is no support for Windows with this build system (yet).

@Dialpuri Dialpuri added the enhancement New feature or request label Sep 6, 2024
@Dialpuri Dialpuri marked this pull request as ready for review November 29, 2024 09:52
@Dialpuri Dialpuri requested a review from glycojones November 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant