added center on click functionality #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With a fairly large change like this, I would like someone to build and test it. |
GABRAH
approved these changes
Oct 19, 2023
| @@ -489,15 +499,15 @@ namespace privateer | |||
| { | |||
| public: | |||
| shadedCircle() { } //!< null constructor | |||
| shadedCircle( int x, int y, std::string message, std::string mmdbsel = "" ) { set_pos(x, y); set_tooltip ( message ); set_mmdbsel(mmdbsel);} | |||
| shadedCircle( int x, int y, std::string message, std::string chainID = "N/A", std::string resname = "N/A", int seqnum = 0, std::string mmdbsel = "" ) { set_pos(x, y); set_tooltip ( message ); set_mmdbsel(mmdbsel); set_chainID(chainID); set_resname(resname); set_seqnum(seqnum);} | |||
There was a problem hiding this comment.
I think I deliberately excluded shaded nodes from including the metadata, but on other hand I can see the benefit of this in case users don't aim their mouse at the sugar nodes themselves.
There was a problem hiding this comment.
Did I change something from your PR here? If I did it wasn't intentional
There was a problem hiding this comment.
My bad, you're right. The change was done by me and I have gone delusional here. Please disregard my comment
I need guidance with this. I wasn't able to get the emcmake to do its thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the code written by @GABRAH in #54
Added frontend centering code to that PR.
Should solve issue #40